Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: remove obsolete external link #28326

Merged
merged 1 commit into from
Jun 22, 2019
Merged

doc: remove obsolete external link #28326

merged 1 commit into from
Jun 22, 2019

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Jun 20, 2019

The addons documentation links to an external node-qt repo as a production example. That repo hasn't been updated in over five years. This commit removes the link.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added addons Issues and PRs related to native addons. doc Issues and PRs related to the documentations. labels Jun 20, 2019
@cjihrig
Copy link
Contributor Author

cjihrig commented Jun 21, 2019

The addons documentation links to an external node-qt repo as
a production example. That repo hasn't been updated in over
five years. This commit removes the link.

PR-URL: nodejs#28326
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@cjihrig cjihrig merged commit c6f959a into nodejs:master Jun 22, 2019
@cjihrig cjihrig deleted the obsolete branch June 22, 2019 17:35
targos pushed a commit that referenced this pull request Jul 2, 2019
The addons documentation links to an external node-qt repo as
a production example. That repo hasn't been updated in over
five years. This commit removes the link.

PR-URL: #28326
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addons Issues and PRs related to native addons. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants